Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update embedding method #88

Merged
merged 3 commits into from
Nov 16, 2024
Merged

feat: update embedding method #88

merged 3 commits into from
Nov 16, 2024

Conversation

jhen0409
Copy link
Member

  • Expose pooling_type / embd_normalize params in initLlama
  • Allow custom embd_normalize param in context.embedding method
  • Add encoder-decoder model check (it not supported computing embeddings)
  • llama_rn_context::getEmbedding: Take llama_pooling_type(ctx) instead of from params

@jhen0409 jhen0409 merged commit 6190f57 into main Nov 16, 2024
4 checks passed
@jhen0409 jhen0409 deleted the update-embd branch November 16, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jhen0409