-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android coding challenge #22
Open
raphaelbgr
wants to merge
48
commits into
myfreecomm:master
Choose a base branch
from
raphaelbgr:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added retrofit + Gradle upgrade + Layout for matches on main screen
+ include data module on android project
+ Had to allow http transport with clear text for downloading team icons
+ Implemented fetchAll() matches and teams on the database
+ Made all model classes parcelable + Implemented BaseActivity
…odule + Independent injector for BaseActivity
+ included test libs + upgrade libraries
+ configuration of instrumented test with MockWebServer + instrumented test loadApiMatchListSuccess() DONE
…ll presenters witch extends from BasePresenter will have the couroutine scope providade by dagger.
Pull request of the complete app, first version
Instrumented test date fix, because of emulator/device GMT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minha proposta é utilizar um desafio que fiz recentemente por questões de tempo, este desafio contempla tudo o que é pedido no desafio da Hexacta, e também mais coisas legais. Está tudo no Readme que editei.