Skip to content

[#3830] Update request base calculated status #2726

[#3830] Update request base calculated status

[#3830] Update request base calculated status #2726

Triggered via pull request October 27, 2023 15:41
Status Failure
Total duration 1m 19s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

rubocop.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 10 warnings
build
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
build
Process completed with exit code 1.
build: app/models/info_request/state/calculator.rb#L96
[rubocop] reported by reviewdog 🐶 [Correctable] Performance/RedundantMerge: Use opts[:in_internal_review] = state == 'internal_review'; opts[:internal_review_requested] = @info_request.internal_review_requested? instead of opts.merge!( Raw Output: app/models/info_request/state/calculator.rb:96:9: C: [Correctable] Performance/RedundantMerge: Use opts[:in_internal_review] = state == 'internal_review'; opts[:internal_review_requested] = @info_request.internal_review_requested? instead of opts.merge!( in_internal_review: state == 'internal_review', internal_review_requested: @info_request.internal_review_requested? ). (https://github.com/JuanitoFatas/fast-ruby#hashmerge-vs-hash-code) opts.merge!( ... ^^^^^^^^^^^^
build: app/models/info_request/state/transitions.rb#L90
[rubocop] reported by reviewdog 🐶 [Correctable] Layout/MultilineOperationIndentation: Align the operands of a condition in an if statement spanning multiple lines. Raw Output: app/models/info_request/state/transitions.rb:90:13: C: [Correctable] Layout/MultilineOperationIndentation: Align the operands of a condition in an if statement spanning multiple lines. opts.fetch(:internal_review_requested, false) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build: app/models/info_request/state/transitions.rb#L144
[rubocop] reported by reviewdog 🐶 [Correctable] Layout/MultilineOperationIndentation: Align the operands of a condition in an if statement spanning multiple lines. Raw Output: app/models/info_request/state/transitions.rb:144:13: C: [Correctable] Layout/MultilineOperationIndentation: Align the operands of a condition in an if statement spanning multiple lines. opts.fetch(:internal_review_requested, false) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build: spec/models/info_request/state/calculator_spec.rb#L259
[rubocop] reported by reviewdog 🐶 [Correctable] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. Raw Output: spec/models/info_request/state/calculator_spec.rb:259:47: C: [Correctable] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. user_asked_to_update_status: false) ^
build: spec/models/info_request/state/calculator_spec.rb#L260
[rubocop] reported by reviewdog 🐶 [Correctable] Layout/LineLength: Line is too long. [91/80] (https://rubystyle.guide#max-line-length) Raw Output: spec/models/info_request/state/calculator_spec.rb:260:81: C: [Correctable] Layout/LineLength: Line is too long. [91/80] (https://rubystyle.guide#max-line-length) expected = %w[internal_review waiting_response waiting_clarification gone_postal] ^^^^^^^^^^^
build: spec/models/info_request/state/calculator_spec.rb#L267
[rubocop] reported by reviewdog 🐶 [Correctable] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. Raw Output: spec/models/info_request/state/calculator_spec.rb:267:47: C: [Correctable] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. user_asked_to_update_status: false) ^
build: spec/models/info_request/state/calculator_spec.rb#L268
[rubocop] reported by reviewdog 🐶 Layout/LineLength: Line is too long. [81/80] (https://rubystyle.guide#max-line-length) Raw Output: spec/models/info_request/state/calculator_spec.rb:268:81: C: Layout/LineLength: Line is too long. [81/80] (https://rubystyle.guide#max-line-length) expected = "I'm still <strong>waiting</strong> for the internal review" ^
build: spec/models/info_request/state/calculator_spec.rb#L277
[rubocop] reported by reviewdog 🐶 [Correctable] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. Raw Output: spec/models/info_request/state/calculator_spec.rb:277:47: C: [Correctable] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. user_asked_to_update_status: false) ^
build: spec/models/info_request/state/calculator_spec.rb#L278
[rubocop] reported by reviewdog 🐶 [Correctable] Layout/LineLength: Line is too long. [91/80] (https://rubystyle.guide#max-line-length) Raw Output: spec/models/info_request/state/calculator_spec.rb:278:81: C: [Correctable] Layout/LineLength: Line is too long. [91/80] (https://rubystyle.guide#max-line-length) expected = %w[internal_review waiting_response waiting_clarification gone_postal] ^^^^^^^^^^^
build: spec/models/info_request/state/calculator_spec.rb#L285
[rubocop] reported by reviewdog 🐶 [Correctable] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. Raw Output: spec/models/info_request/state/calculator_spec.rb:285:47: C: [Correctable] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. user_asked_to_update_status: false) ^