Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker install guide changes #7824

Closed

Conversation

FozzieHi
Copy link
Contributor

@FozzieHi FozzieHi commented Jul 13, 2023

What does this do?

  • Change setup arguments - This is through my limited understanding of scripts, so please correct me if I'm wrong! In the docker/setup script, data_reset is defined as data_reset="${1:-false}". This means that data_reset is either the first command-line argument if present, or false otherwise. So in order to run the migration, sample data and xapian index you would have to specify ./docker/setup true. Given the current description in the installation guide is to do this, I think we should include the command line argument.
  • Adds a section on how to visit the MailHog instance.
  • Minor grammar fixes.

Why was this needed?

To solve issues with databases after Docker installation, and to provide more information in the docs.

Copy link
Member

@gbp gbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Not sure how I didn't catch this before.

I will change the setup script so passing in true isn't necessary.

@gbp
Copy link
Member

gbp commented Oct 19, 2023

Fixed setup script in #7965, merged other changes in 81cc657

@gbp gbp closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants