[#1106] Admin view of unmasked incoming message #7999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
approved these changes
Nov 10, 2023
Admins often want to view the contents of an incoming message without any masking or censor rules applied. In some cases you can inspect the raw email, but it's often base64 encoded, which means needing to download the email and open it in a mail client. Even when the email is not base64 encoded, it's often difficult to mentally parse the information out when there are lots of headers, attachment sections and HTML body content. This commit adds an unmasked view of main body part attachments. This is equivalent to the main body contents of an incoming message that we show in public. This does require "downloading" the attachment from Active Storage, but at present we use local file storage for attachments, so that's fine. Even if we moved them to S3 it wouldn't be a disaster to fetch them each time, as this isn't a frequently viewed page. Needed to use an `!important` CSS rule to improve the visual rendering as for some reason bootstrap sets `margin-bottom: 0;` on `p` tags within a `blockquote` element (See bootstrap-sass-2.3.2.2/vendor/assets/stylesheets/bootstrap/_type.scss). Fixes #1106.
garethrees
force-pushed
the
1106-unmasked-incoming-message-body
branch
from
fb43721 to
f6bbc01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admins often want to view the contents of an incoming message without any masking or censor rules applied.
In some cases you can inspect the raw email, but it's often base64 encoded, which means needing to download the email and open it in a mail client. Even when the email is not base64 encoded, it's often difficult to mentally parse the information out when there are lots of headers, attachment sections and HTML body content.
This commit adds an unmasked view of main body part attachments. This is equivalent to the main body contents of an incoming message that we show in public.
This does require "downloading" the attachment from Active Storage, but at present we use local file storage for attachments, so that's fine. Even if we moved them to S3 it wouldn't be a disaster to fetch them each time, as this isn't a frequently viewed page.
Needed to use an
!importantCSS rule to improve the visual rendering as for some reason bootstrap setsmargin-bottom: 0;onptags within ablockquoteelement (Seebootstrap-sass-2.3.2.2/vendor/assets/stylesheets/bootstrap/_type.scss).
Fixes #1106.