Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clarity of both_links for FoiAttachment #8010

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

garethrees
Copy link
Member

Prepending the info request title adds extra noise when viewing the list of an attachments for an incoming message. We lose a bit of context if rendering both_links for an attachment outside of its request/incoming message page, but I don't think we do that at present and it's worth the tradeoff. In a situation where we do want both, then we can add it in in that specific context.

BEFORE

Screenshot 2023-11-14 at 11 50 08

AFTER

Screenshot 2023-11-14 at 11 50 02

[skip changelog]

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Prepending the info request title adds extra noise when viewing the list
of an attachments for an incoming message. We lose a bit of context if
rendering `both_links` for an attachment outside of its request/incoming
message page, but I don't think we do that at present and it's worth the
tradeoff. In a situation where we do want both, then we can add it in in
that specific context.
@garethrees garethrees marked this pull request as ready for review November 27, 2023 15:01
@garethrees garethrees merged commit df55e42 into develop Nov 28, 2023
@garethrees garethrees deleted the foi-attachment-both-links-tweak branch November 28, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants