[Waste] Don’t call backend APIs for static template calendar page

mysociety · Oct 1, 2024 · a3b842d · a3b842d
1 parent 4b431c7
commit a3b842d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/perllib/FixMyStreet/App/Controller/Waste.pm b/perllib/FixMyStreet/App/Controller/Waste.pm
@@ -568,9 +568,14 @@ sub csc_payment_failed : Path('csc_payment_failed') : Args(0) {
     $c->detach;
 }
 
-sub property : Chained('/') : PathPart('waste') : CaptureArgs(1) {
+sub property_id : Chained('/') : PathPart('waste') : CaptureArgs(1) {
     my ($self, $c, $id) = @_;
+    $c->stash->{property_id} = $id;
+}
 
+sub property : Chained('property_id') : PathPart('') : CaptureArgs(0) {
+    my ($self, $c) = @_;
+    my $id = $c->stash->{property_id};
 
     # Some actions chained off /waste/property require user to be logged in.
     # The redirect to /auth does not work if it follows the asynchronous
@@ -670,9 +675,8 @@ sub bin_day_deny : Private {
     $c->detach('/page_error_403_access_denied', [ $msg ]);
 }
 
-sub calendar : Chained('property') : Args(0) {
+sub calendar : Chained('property_id') : Args(0) {
     my ($self, $c) = @_;
-
     $c->forward('/about/page', ['waste-calendar']);
 }
 

diff --git a/templates/web/fixmystreet-uk-councils/about/waste-calendar.html b/templates/web/fixmystreet-uk-councils/about/waste-calendar.html
@@ -1,6 +1,6 @@
 [%
 PROCESS 'waste/header.html', title = 'Add your waste collection days to your online calendar';
-SET ics_link = c.uri_for_action('waste/calendar_ics', [ property.id ]);
+SET ics_link = c.uri_for_action('waste/calendar_ics', [ property_id ]);
 %]
 
 <script type="module" src="[% version('/vendor/clipboard-copy-element.js') %]"></script>