Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brent] Increase Green Garden Waste renewal window #4787

Merged

Conversation

MorayMySoc
Copy link
Contributor

Change Brent's ggw renewal from 28 days to 90 days so users can renew from the beginning of the year.

https://mysocietysupport.freshdesk.com/a/tickets/3693

[skip changelog]

@MorayMySoc MorayMySoc requested a review from dracos January 10, 2024 10:22
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (79bead8) 85.31% compared to head (f33e8d2) 51.96%.

❗ Current head f33e8d2 differs from pull request most recent head f54c05e. Consider uploading reports for the commit f54c05e to get more accurate results

Files Patch % Lines
perllib/FixMyStreet/Cobrand/Brent.pm 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4787       +/-   ##
===========================================
- Coverage   85.31%   51.96%   -33.36%     
===========================================
  Files         341      338        -3     
  Lines       24693    24436      -257     
  Branches     4685     4639       -46     
===========================================
- Hits        21067    12698     -8369     
- Misses       2200    10474     +8274     
+ Partials     1426     1264      -162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think should be fine!

Change Brent's ggw renewal from 28 days to 90 days so
users can renew from the beginning of the year.

https://mysocietysupport.freshdesk.com/a/tickets/3693
@mysociety-pusher mysociety-pusher force-pushed the 3693-helpdesk-extend-brent-ggw-renewal-window branch from f33e8d2 to f54c05e Compare January 10, 2024 11:38
@mysociety-pusher mysociety-pusher merged commit f54c05e into master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants