-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brent] Add payment for some containers. #5274
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5274 +/- ##
==========================================
+ Coverage 82.41% 82.42% +0.01%
==========================================
Files 416 416
Lines 32904 32914 +10
Branches 5284 5287 +3
==========================================
+ Hits 27117 27131 +14
+ Misses 4226 4222 -4
Partials 1561 1561 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks OK to me but there are a few things I have questions about.
bbb3f90
to
938046c
Compare
ebf99e1
to
c5a9917
Compare
c5a9917
to
9bd1c44
Compare
[skip changelog] Fixes https://github.com/mysociety/societyworks/issues/4589
(changes from WIP. -I moved the set up of payment into the about_you next because in the replacement next we don’t yet have the answer to the “how_long_lived” question, and I don’t think we need a special page about payment, they can stick whatever text they want in the intro)