Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bristol] Add layers for allowed reports #5343

Conversation

MorayMySoc
Copy link
Contributor

Setup for two asset layers to have either selected to allow reports in Bristol on relevant categories.

https://github.com/mysociety/societyworks/issues/4692

Configuration in same branch on the servers

[skip changelog]

@MorayMySoc MorayMySoc requested a review from neprune January 27, 2025 15:20
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (61e7964) to head (25b205e).
Report is 6 commits behind head on bristol-main-alloy-integration.

Files with missing lines Patch % Lines
web/cobrands/fixmystreet-uk-councils/assets.js 29.41% 12 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           bristol-main-alloy-integration    #5343      +/-   ##
==================================================================
- Coverage                           82.42%   82.39%   -0.03%     
==================================================================
  Files                                 416      416              
  Lines                               32925    32942      +17     
  Branches                             5289     5289              
==================================================================
+ Hits                                27137    27142       +5     
- Misses                               4225     4237      +12     
  Partials                             1563     1563              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neprune neprune removed their request for review January 29, 2025 12:44
@dracos dracos force-pushed the bristol-main-alloy-integration-assetlayers branch from d5fb4a9 to c0c2f69 Compare February 3, 2025 16:56
@dracos
Copy link
Member

dracos commented Feb 3, 2025

@MorayMySoc have pushed commit to check staff, and store both flags separately

@dracos dracos changed the base branch from master to bristol-main-alloy-integration February 3, 2025 18:29
MorayMySoc and others added 2 commits February 3, 2025 22:11
Setup for two asset layers to have either selected to allow reports
in Bristol on relevant categories.

mysociety/societyworks#4692
@dracos dracos force-pushed the bristol-main-alloy-integration-assetlayers branch from c0c2f69 to 25b205e Compare February 3, 2025 22:11
@dracos dracos merged commit c04d583 into bristol-main-alloy-integration Feb 4, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants