[National Highways] Only include NH reports in alerts #5344
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5344 +/- ##
=======================================
Coverage 82.42% 82.42%
=======================================
Files 416 416
Lines 32925 32926 +1
Branches 5289 5290 +1
=======================================
+ Hits 27138 27139 +1
+ Misses 4225 4224 -1
- Partials 1562 1563 +1 ☔ View full report in Codecov by Sentry. |
dracos
changed the title
We do not want to include non-NH reports within a NH alert.
dracos
force-pushed
the
nh-fix-base-url-for-reports
branch
from
f8da493 to
09d08a7
Compare
davea
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/mysociety/societyworks/issues/4747
[skip changelog]