[Southwark] Include user email in CSV report export. #5345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5345 +/- ##
==========================================
+ Coverage 82.41% 82.44% +0.02%
==========================================
Files 416 416
Lines 32904 32911 +7
Branches 5284 5286 +2
==========================================
+ Hits 27117 27132 +15
+ Misses 4226 4217 -9
- Partials 1561 1562 +1 ☔ View full report in Codecov by Sentry. |
neprune
force-pushed
the
southwark-email-in-export
branch
from
42a2be6 to
fea0f9e
Compare
neprune
commented
Jan 27, 2025
Comment on lines
+289
to
+292
| $csv->objects_attrs({ | ||
| '+columns' => ['user.email'], | ||
| join => 'user', | ||
| }); |
There was a problem hiding this comment.
Didn't manage to grok what this block is for, just copied it over from Bexley which had the same set-up. Enlightenment appreciated.
dracos
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://mysocietysupport.freshdesk.com/a/tickets/5051
[skip changelog]