Add option to allow users to hide speaker votes in alerts #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struan
force-pushed
the
alert-front-end-vector-suggestions
branch
3 times, most recently
from
e27eb1b to
761080e
Compare
Slowed down the front page enough to trigger an alert.
struan
force-pushed
the
alerts-skip-votes-option
branch
from
5cf7a02 to
075ce8d
Compare
struan
force-pushed
the
alerts-skip-votes-option
branch
2 times, most recently
from
3a66f7f to
9dfac30
Compare
struan
changed the base branch from
alert-front-end-vector-suggestions
to
alert-front-end-small-fixes
struan
force-pushed
the
alerts-skip-votes-option
branch
from
9dfac30 to
bd9f0c2
Compare
- switch to poetry based approach - create new python data using src - configure linting via ruff - vscode settings update
- Wrap commonlib config access in a pydantic model - Transform types and reveal settings to python IDE
- include sqlalchemy engine for pandas
lucascumsille
force-pushed
the
alerts-skip-votes-option
branch
from
97070f9 to
f7cfffa
Compare
- Use header structure in new data and add basic css styling to the contents.
Useful for doing DB things in development
Makes it easier to split out the different alert types on the alert page. Splits them into alerts with keywords, alerts for when someone speaks and alerts for the user's members.
To make it a bit easier to pick out the different parts of an alert update prettifyCritera to return the parts as a hash instead of turning it into a string.
used to store alert keyword suggestions based on related terms
If there's a square bracket in a get/post param then assume it's a multi value param and create/extend an array for the values so we can test forms with these.
Update constituency search to allow it to return all constituencies for a postcode instead of just westminster. Add a function to get a list of member ids from a search string.
Alert list splits alerts into keyword and representative alerts. New alert creation wizard which makes complicated alerts easier to create and also suggests related terms if we have any. Also allows editing alerts. Retains existing form for adding MP/postcode alerts.
lucascumsille
force-pushed
the
alerts-skip-votes-option
branch
from
4dd0a95 to
acf8860
Compare
|
@struan I added some commits to tidy up indentation and class name convention, but I think I still need some time to work on this. |
struan
force-pushed
the
alerts-skip-votes-option
branch
from
acf8860 to
ccf1921
Compare
Used to allow people to suppress seeing votes in speaker alerts.
Skips over the vote section if the flag is present.
This also tidies up editing MP alerts so it's mostly buttons rather than having to go through a form.
Without context it was a bit unclear what the "Delete all" button does. The new copy clarifies the button will delete all alerts. The new aria-label will also make sure assistive devices know this includes keywords and representative alerts.
This way it should be clearer the button will delete both keywords and representative alerts
Move to the left so it's easier to spot for the user. On the right semmed a bit out of place.
- Improved naming for keyword alert list(New name is more self explanatory) - New classes use BEM convention
There is already a .button--red, .button--negative
It will be less confusing when trying to make future changes. I have also added the BEM classes to the current elements using the tags.
struan
force-pushed
the
alerts-skip-votes-option
branch
from
ad15d45 to
3e41a34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets users set a flag on an alert to avoid including recent votes in an alert for "when x speaks"
Part of #1825