- MMS client: fixed bug in log entry parsing (#224)

mz-automation · Apr 2, 2020 · 4871989 · 4871989
1 parent 95f751e
commit 4871989
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/examples/server_example_logging/server_example_logging.c b/examples/server_example_logging/server_example_logging.c
@@ -33,10 +33,12 @@ sigint_handler(int signalId)
 }
 
 static ControlHandlerResult
-controlHandlerForBinaryOutput(void* parameter, MmsValue* value, bool test)
+controlHandlerForBinaryOutput(ControlAction action, void* parameter, MmsValue* value, bool test)
 {
-    if (test)
+    if (test) {
+        printf("Received test command\n");
         return CONTROL_RESULT_FAILED;
+    }
 
     if (MmsValue_getType(value) == MMS_BOOLEAN) {
         printf("received binary control command: ");
@@ -148,7 +150,7 @@ main(int argc, char** argv)
 
     IedServer_setLogStorage(iedServer, "GenericIO/LLN0$EventLog", statusLog);
 
-#if 0
+#if 1
     uint64_t entryID = LogStorage_addEntry(statusLog, Hal_getTimeInMs());
 
     MmsValue* value = MmsValue_newIntegerFromInt32(123);

diff --git a/src/mms/iso_mms/client/mms_client_journals.c b/src/mms/iso_mms/client/mms_client_journals.c
@@ -67,7 +67,7 @@ parseJournalVariable(uint8_t* buffer, int bufPos, int maxLength, MmsJournalVaria
         case 0xa1: /* valueSpec */
 
             if (journalVariable->value == NULL) {
-                journalVariable->value = MmsValue_decodeMmsData(buffer, bufPos, length, NULL);
+                journalVariable->value = MmsValue_decodeMmsData(buffer, bufPos, bufPos + length, NULL);
             }
 
             break;