Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin cryptography, and set minimum version to 44.0.1 #691

Open
wants to merge 1 commit into
base: release
Choose a base branch
from

Conversation

aetherknight
Copy link

The Cryptography library doesn't follow SemVer for its versioning. Instead, it increments its major version any time it adds a new feature: https://cryptography.io/en/latest/api-stability/

Due to their versioning policy, and because their updates often address security issues in older versions, I would like to propose removing the maximum version constraint for cryptography.

If someone runs into a problem due to a removed symbol (eg, if something completely removes support for an old SSL/TLS version or removes a cipher suite that sslyze directly references), then they can be advised to try downgrading cryptography to an older version (at the risk of having certain vulns included).

This PR also addresses https://osv.dev/vulnerability/GHSA-79v4-65xg-pq4g by updating the minimum version of cryptography.

@nabla-c0d3
Copy link
Owner

I think this change will cause people who want to use SSLyze and are unfamiliar with the cryptography package or its lack of SemVer to put the blame on SSLyze (by opening GH issues etc.) when something breaks.

To me, it seems better to have people who are actually familiar with this matter to have them "force-install" a newer version of cryptography.

Not 100% sure about this but these are my thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants