Avoid onion listen port collision #553
Merged
Cirrus CI / lint
failed
Nov 3, 2024 in 1m 45s
Task Summary
Instruction lint failed in 00:45
Details
✅ 00:03 clone
✅ 00:11 merge_base
✅ 00:01 test_runner
✅ 00:05 python
✅ 00:35 unshallow
❌ 00:45 lint
[09:59:44.969] A new circular dependency in the form of "qt/nametablemodel -> qt/walletmodel -> qt/nametablemodel" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "rpc/blockchain -> rpc/names -> rpc/blockchain" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "rpc/blockchain -> rpc/rawtransaction -> rpc/blockchain" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "script/names -> script/script -> script/names" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "txdb -> validation -> txdb" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "chain -> node/blockstorage -> pow -> chain" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "chain -> node/blockstorage -> validation -> chain" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "consensus/tx_verify -> names/main -> txmempool -> consensus/tx_verify" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "consensus/tx_verify -> names/main -> validation -> consensus/tx_verify" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "kernel/chainstatemanager_opts -> txdb -> validation -> kernel/chainstatemanager_opts" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "chain -> node/blockstorage -> validation -> deploymentstatus -> chain" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "chain -> node/blockstorage -> validation -> kernel/chain -> chain" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "chain -> node/blockstorage -> validation -> txmempool -> chain" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "chain -> node/blockstorage -> validation -> validationinterface -> chain" appears to have been introduced.
[09:59:44.969]
[09:59:44.969] A new circular dependency in the form of "chain -> node/blockstorage -> validation -> versionbits -> chain" appears to have been introduced.
[09:59:44.969]
[09:59:44.976] ^---- ⚠️ Failure generated from lint-circular-dependencies.py
[09:59:47.147] TODO:15: reenable ==> re-enable
[09:59:47.147] contrib/namecoin/convertAddress.py:30: occurances ==> occurrences
[09:59:47.147] src/cluster_linearize.h:674: Unusued ==> Unused
[09:59:47.147] src/ipc/protocol.h:57: neccessary ==> necessary
[09:59:47.147] src/pow.cpp:153: signficant ==> significant
[09:59:47.147] test/functional/feature_assumeutxo.py:739: reenable ==> re-enable
[09:59:47.147] test/functional/name_wallet.py:214: non-existant ==> non-existent
[09:59:47.147] test/functional/test_runner.py:290: Reenable ==> Re-enable
[09:59:47.147] test/functional/test_runner.py:362: Reenable ==> Re-enable
[09:59:47.147] ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
[09:59:47.485] The locale dependent function fprintf(...) appears to be used:
[09:59:47.485] src/bench/bench_bitcoin.cpp: fprintf(stderr, "bench_bitcoin is disabled in Namecoin/Auxpow\n");
[09:59:47.485]
[09:59:47.485] Unnecessary locale dependence can cause bugs that are very tricky to isolate and fix. Please avoid using locale-dependent functions if possible.
[09:59:47.485]
[09:59:47.485] Advice not applicable in this specific case? Add an exception by updating the ignore list in /tmp/cirrus-ci-build/test/lint/lint-locale-dependence.py
[09:59:47.490] ^---- ⚠️ Failure generated from lint-locale-dependence.py
[09:59:47.524] Missing "export LC_ALL=C" (to avoid locale dependence) as first non-comment non-empty line in contrib/auxpow/getwork-wrapper.sh
[09:59:47.524] Missing "export LC_ALL=C" (to avoid locale dependence) as first non-comment non-empty line in contrib/namecoin/convertBechAddress.sh
[09:59:47.524] Missing "export LC_ALL=C" (to avoid locale dependence) as first non-comment non-empty line in share/pixmaps/generate_icns.sh
[09:59:47.530] ^---- ⚠️ Failure generated from lint-shell-locale.py
[09:59:47.646]
[09:59:47.646] ^---- ⚠️ Failure generated from lint check 'all_python_linters'!
[09:59:47.646] Run all linters of the form: test/lint/lint-*.py
�������������������������������������������������������
Loading