Add CopyObject Function #128 #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I'm disappointed that some Firefox tests are still failing when I thought I fixed that, but that doesn't look like it's this PR's fault. |
|
The "Go Lint New" failure affects the whole repo, and I won't make you fix that in this PR. |
JeremyRand
reviewed
Oct 15, 2022
JeremyRand
reviewed
Oct 15, 2022
JeremyRand
reviewed
Oct 15, 2022
|
ACK 48a757a , modulo the 3 comments above. |
|
I'll check on Go Lint New, to determine what is causing the failures |
|
Go Lint New returning an error: "return with no blank line before" But the return statement is alone inside a statement group. |
JeremyRand
reviewed
Oct 15, 2022
JeremyRand
reviewed
Oct 15, 2022
JeremyRand
reviewed
Oct 15, 2022
|
Accidentally closed the PR when force pushing :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CopyObject Function #128