tests: workaround clang bug with parameter pack after default argument

Change-Id: I69a2f9cbd5eddef9501fecc8a5438301d01ed885
named-data · Jan 16, 2025 · 2b43d67 · 2b43d67 · pulsejet · Jan 30, 2025
1 parent 4296fe3
commit 2b43d67
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/tests/daemon/mgmt/face-manager.t.cpp b/tests/daemon/mgmt/face-manager.t.cpp
@@ -63,7 +63,7 @@ class FaceManagerFixture : public ManagerFixtureWithAuthenticator
    */
   template<typename... Args>
   shared_ptr<Face>
-  addFace(unsigned int flags = 0, Args&&... args)
+  addFace(unsigned int flags, Args&&... args)
   {
     auto face = make_shared<DummyFace>(std::forward<Args>(args)...);
     m_faceTable.add(face);
@@ -91,6 +91,15 @@ class FaceManagerFixture : public ManagerFixtureWithAuthenticator
     return face;
   }
 
+  // We cannot combine this overload with the previous one
+  // because clang 10 (and earlier) doesn't like it.
+  // This is a workaround for https://github.com/llvm/llvm-project/issues/23403
+  shared_ptr<Face>
+  addFace()
+  {
+    return addFace(0);
+  }
+
 private:
   template<typename T>
   static void