Various fixes #64
Merged
Various fixes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reason for copying the frame? |
The ndnlp link service uses a single outgoing buffer that is passed to the downstream transport (to save mallocgc; I profiled this and the overhead was significant ~5%). The downstream transport must synchronously copy the buffer to OS memory. In this case it loops back to us, so we need to copy it ourselves. |
pulsejet
force-pushed
the
varun/patch-1
branch
from
5be6dc6 to
bad183a
Compare
pulsejet
force-pushed
the
varun/patch-1
branch
from
e482f36 to
7cac9d7
Compare
|
Thanks for taking a look @zjkmxy , I was worried the changes are a bit too wild to review easily xD Almost done now for this PR, just need a new tag on go-ndn. Next PR I'll check/fix the other transports (likely only unix works at the moment) |
Tagged as |
16 tasks
zjkmxy
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not for review yet - will also need tag on go-ndn