Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1672 Video Block autoplay option #707

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Feature/1672 Video Block autoplay option #707

merged 3 commits into from
Dec 3, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Nov 26, 2024 •
edited
Loading

Supports:

To test:

  1. make vue-storybook
  2. view the stories of changed components. Note that usage of MixinVideoBg in HeroMedia will always loop the video. This means the "autoplay" checkbox that appears to editors in this context has no effect (see https://github.com/nasa-jpl/www-backend/pull/1176)

Scotchester
Scotchester approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@Scotchester Scotchester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@stephiescastle stephiescastle merged commit 232c7b4 into main Dec 3, 2024
7 checks passed
@stephiescastle stephiescastle deleted the feature/1672-video-autoplay branch December 3, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scotchester Scotchester Scotchester approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephiescastle @Scotchester