Fix FileUplink packet sequence repeat and CRC #1378 #3007
Merged
+125
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+188
to
+189
| bool FileUplink :: | ||
| checkDuplicatedPacket(const U32 sequenceIndex) |
Check notice
Code scanning / CodeQL
Use of basic integral type Note
| ) | ||
| { | ||
| this->m_fileUplink->log_WARNING_HI_PacketDuplicate( | ||
| sequenceIndex |
Check warning
Code scanning / CodeQL
Unchecked function argument Warning
LeStarch
approved these changes
Nov 6, 2024
|
@timcanham would you review too, given you were more involved with this work? |
timcanham
reviewed
Nov 6, 2024
|
Thanks @DJKessler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added duplicate packet detection based on sequence number
FileUplinkmember variable