DAS-2280: Rough start at implementing no rasterizing 1-band images #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(clarify comment in browse.py)
now we just drop the alpha if it's a jpeg from a one band
flamingbear
changed the title
These might be useful to add back some day. But aren't needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the rough start at how I would fix DAS-2280. I didn't have enough time to get to fixing the unit and regression tests. But I think the code is working for 1band + colormap and the 1band with no colors is also generating grayscale images. I'm not 100% sure those are equal to how they were before, but now they are normalized linearly from min and max values to 0-254
Jira Issue ID
DAS-2280
Local Test Steps
Not ready for testing.
PR Acceptance Checklist
CHANGELOG.mdupdated to include high level summary of PR changes.docker/service_version.txtupdated if publishing a release.