#1088: Tool to fix already-produced disp s1 iso.xml file in-place in S3 #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RKuttruff
reviewed
Feb 18, 2025
tools/fix_disp_s1_iso_xml_from_s3.py
Outdated
Comment on lines
59
to
62
| # Remove string that starts with <gco:CharacterString>{"algorithm_theoretical_basis_document_id and then ends with </gco:CharacterString> | ||
| xml = re.sub( | ||
| r'<gco:CharacterString>{"algorithm_theoretical_basis_document_id.*?</gco:CharacterString>', | ||
| '87600.0', xml, flags=re.DOTALL) |
There was a problem hiding this comment.
I believe the <gco:CharacterString> tag is required still even for float values
There was a problem hiding this comment.
Good catch @RKuttruff Just fixed it. Good thing is that the code worked even with that incorrect substitution.
…rder of magnitude
hhlee445
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Proposed Changes
Issues
Testing