Fix CommandArgumentEnumerator behavior for .NET 8 #544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #541
There's been a breaking change in .NET 8. The behavior for
IEnumerator.Current
, which has always been undefined when called afterMoveNext()
returned false, has changed from "return the last value" to "throw an exception". So instead of calling_enumerator.Current
every timeCurrent
is invoked, we now store the value of_enumerator.Current
after_enumerator.MoveNext()
returned true.I also added the
net8.0
TFM to the unit tests to validate the behavior is now correct on .NET 8.