Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve SVG rendering as black rectangle #109

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Resolve SVG rendering as black rectangle #109

merged 7 commits into from
Sep 18, 2024

Conversation

keithnewman
Copy link
Collaborator

@keithnewman keithnewman commented Sep 18, 2024 •
edited
Loading

Content security policy does not allow the CSS to be built into the SVG object.

Also a number of tweaks to the HTML and CSS so that:

  • Text is not aligned using the deprecated align argument in HTML tags.
  • the bold sections of the homepage main title are emphasised as the HTML suggests it was intended to be.
  • a non-standard apostrophe is replaced.

@keithnewman keithnewman self-assigned this Sep 18, 2024
@keithnewman keithnewman changed the base branch from live to stage September 18, 2024 12:29
@keithnewman keithnewman changed the title Draft: Move CSS out of SVG Move CSS out of SVG Sep 18, 2024
@keithnewman keithnewman changed the title Move CSS out of SVG Resolve SVG rendering as black rectangle Sep 18, 2024
jrrichardbrown
jrrichardbrown approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@jrrichardbrown jrrichardbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev. Now working

@jrrichardbrown jrrichardbrown merged commit 62205ee into stage Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrrichardbrown jrrichardbrown jrrichardbrown approved these changes

Assignees

@keithnewman keithnewman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithnewman @jrrichardbrown