[FIXED] Default statistics handler of microservice had unnecessary ch…

…eck (#837) The default handler was invoked with a request that was already checked to have a service associated. The handler was extracting the service (that was not needed) and had an incorrect check such as `if ((m == NULL) || (m == NULL))`. Resolves #833 Signed-off-by: Ivan Kozlovic <[email protected]>
nats-io · Feb 16, 2025 · 6d6590b · 6d6590b
1 parent 7220e9f
commit 6d6590b
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/src/micro_monitoring.c b/src/micro_monitoring.c
@@ -81,13 +81,9 @@ static microError *
 handle_stats_default(microRequest *req)
 {
     microError *err = NULL;
-    microService *m = microRequest_GetService(req);
     microServiceStats *stats = NULL;
     natsBuffer *buf = NULL;
 
-    if ((m == NULL) || (m == NULL))
-        return micro_ErrorInvalidArg; // Should not happen
-
     MICRO_CALL(err, microService_GetStats(&stats, req->Service));
     MICRO_CALL(err, marshal_stats(&buf, stats));
     MICRO_CALL(err, microRequest_Respond(req, natsBuf_Data(buf), natsBuf_Len(buf)));