Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(avatar): refactor props and some styles #267

Open
wants to merge 1 commit into
base: refactor-v2
Choose a base branch
from
Open

fix(avatar): refactor props and some styles #267

wants to merge 1 commit into from

Conversation

alex-britto
Copy link

  • Remove as propriedades letter e children.
  • Adiciona propriedade name.
  • Corrige border-radius de acordo com o Figma para a a variant Variant.
  • Corrige visualização do status, que está ficando recortado quando a prop avatar está vazia.

igorcasconi
igorcasconi reviewed Mar 8, 2022
View reviewed changes
src/components/Avatar/Avatar.jsx
@@ -126,6 +126,15 @@ const Avatar = ({ avatar, letter, size, status, variant, children, ...props }) =
}
}

const formatInitials = name => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eu acho melhor adicionar essa função em utils e importar dentro do arquivo do avatar, o que tu acha?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorcasconi igorcasconi igorcasconi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-britto @igorcasconi