Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1568 bucket enumeration failure oci #1569

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

WhiteThePanda
Copy link

@WhiteThePanda WhiteThePanda commented Aug 30, 2023

Description

Make sure the PR is against the develop branch (see Contributing).

Make sure to set the corresponding milestone in the PR.

Ran against OCI tenancies, the tool could not proprely parse the namespace of the tenancy for bucket retrieval.
I think the issue was due to the problem addressed by this comment in the code, when retrieving the namespace from the API:
" # for some reason it returns a list of chars instead of a string"
I guess the response of the API on OCI's side has changed and the namespace is now retrieved as a whole string. Code was updated in consequence to make adequate use of the API.

Fixes #1568

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

(Sorry, this is my first pull-request ever in my life and I am not sure on how to use the tests (I am only using OCI), I have verified my work by running the tool with my personal credentials)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants