Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

nci / scores Public

Notifications You must be signed in to change notification settings
Fork 27
Star 93

Code
Issues 65
Pull requests 9
Discussions
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

114 add circular block bootstrapping #418

Merged

tennlee merged 34 commits into develop from 114-add-circular-block-bootstrapping

Feb 12, 2025

Merged

114 add circular block bootstrapping #418

tennlee merged 34 commits into develop from 114-add-circular-block-bootstrapping

Feb 12, 2025

Conversation 107 Commits 34 Checks 13 Files changed

Conversation

Copy link

Collaborator

reza-armuei commented May 23, 2024 •

edited by nicholasloveday

Loading

Testing

100% unit test coverage
Test that metric is compatible with dask.
Test that metrics work with inputs that contain NaNs
Test that errors are raised as expected
Test that it works with both xr.Dataarrays and xr.Datasets

Notebook

Tutorial notebook

Documentation

Add the score to the API documentation
Add the score to the included list of metrics and tools
Example in docstring
Error messages in docstring

Sorry, something went wrong.

All reactions

reza-armuei linked an issue

that may be closed by this pull request

Add circular block bootstrapping #114

Closed

reza-armuei requested review from tennlee, nikeethr and nicholasloveday

May 23, 2024 03:26

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr reviewed

View reviewed changes

src/scores/processing/block_bootstrap.py Outdated Show resolved Hide resolved

nikeethr marked this pull request as draft

May 25, 2024 11:13

This comment was marked as resolved.

Sign in to view

Sorry, something went wrong.

nikeethr changed the title ~~114 add circular block bootstrapping~~ (requires design discussion) 114 add circular block bootstrapping

nikeethr force-pushed the 114-add-circular-block-bootstrapping branch from 5191ad2 to 90bcf78 Compare

May 28, 2024 05:10

This comment was marked as resolved.

Sign in to view

nikeethr force-pushed the 114-add-circular-block-bootstrapping branch 2 times, most recently from 8429051 to d703d87 Compare

June 11, 2024 00:39

nikeethr added the emerging label

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

nikeethr mentioned this pull request

Cyclic/Circular block bootstrapping - refactor #522

Open

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

nicholasloveday added 3 commits

February 10, 2025 16:21


          rename and mock max batch size constant

0f43dcd


          renmae bootstrap file

cd75ce6


          use monkeypatch instead

38d914f

This comment was marked as resolved.

Sign in to view

nicholasloveday added 5 commits

February 10, 2025 20:29


          add raises to docstring

8893b9c


          improve error message

40242ab


          add example

87ba2f3


          removed potential clash of dim names

eeac8ef


          add dependency into data in the tutorial so that it's not just random…

a0d15be

… noise

nicholasloveday changed the title ~~(under development) 114 add circular block bootstrapping~~ 114 add circular block bootstrapping

nicholasloveday marked this pull request as ready for review

February 12, 2025 02:04

This comment was marked as resolved.

Sign in to view

reza-armuei commented

View reviewed changes

Copy link

Collaborator Author

reza-armuei left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicholasloveday I only reviewed the block bootstrapping tutorial and your changes make sense to me. Thanks

Sorry, something went wrong.

All reactions

tutorials/Block_Bootstrapping.ipynb Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view


          Update tutorials/Block_Bootstrapping.ipynb

ee696f6

Co-authored-by: reza-armuei <[email protected]>
Signed-off-by: Tennessee Leeuwenburg <[email protected]>

nikeethr mentioned this pull request

Block bootstrap: verify performance & accuracy against legacy xbootstrap #819

Closed

Copy link

Collaborator

nikeethr commented Feb 12, 2025

@nicholasloveday LGTM for now, I've offloaded the regression comparison with xbootstrap to #819 .

nicholasloveday reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

nikeethr mentioned this pull request

For consideration: performance tests and benchmarking #820

Open

tennlee mentioned this pull request

Benchmarking merged block bootstrapping against original package #821

Open

tennlee merged commit f46a62d into develop

13 checks passed

tennlee deleted the 114-add-circular-block-bootstrapping branch

February 13, 2025 09:54

tennlee mentioned this pull request

Circular Block Bootstrapping migration #808

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nikeethr nikeethr left review comments

nicholasloveday nicholasloveday left review comments

tennlee tennlee left review comments

Steph-Chong Steph-Chong left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add circular block bootstrapping

6 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.