-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SoilTaxonomyDendrogram.R #45
Conversation
- default uses order, suborder, greatgroup and subgroup - alternately can pick just one, or a couple - if more than one level, last one in vector is used as labels
Also in a3ea312 added |
OK, I like the I'd prefer to wait until after WCSS before merging this, unless I have a very productive weekend. |
Changing the default column names is not a condition of merging this PR. This PR simply adds support for users who have a SPC that has standard NASIS column names in it (and the |
I think we should probably merge this and deal with any other remaining issues outside this PR. |
Thanks for discussion. Good to merge. |
- default `level` is now a named character (default columns may change in future) - re-arrange some notes/messages
Here are some suggested changes to make
SoilTaxonomyDendrogram()
more robust to alternate data sources. If they seem reasonable these changes may be made here, and then ultimately replaced with a dedicated new function from SoilTaxonomy so that ordered factor representation can be reused in other functions.