Add support for round screens, color and SDK 3 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a title bar layer 'class' used to show the feed on the headline menulist page. Fix the layout of the story page on round watchfaces (may break formatting for rectangular faces). Allow the story to flow and scroll correctly. Provide a progress load bar for transfering the story from phone to watch. To achieve this the buffer size is decreased to 128 bytes, which may need tweaking.
Fix the way subscriptions are shown on aplite and basalt emulators. Tweak the status bar location, centering of the menu selection and colours to suit each platform.
Move colour configuration into the settings file. Define a structure for setting up colour schemes. Set colours when a window appears (as opposed to when it loads). Define suitable colours for both colour and B&W displays.
The buffer sizes cause problems for aplite watches due to lack of memory. The code set them to app_message_inbox_size_maximum and app_message_outbox_size_maximum which was 8k for SDK 4.0. This size also seemed unecessary, so this reduces both to 440B. This should be enough for the largest headline (160B) and the largest feed name (30B) as set in main.js. Also fix the wscript which was copying all of the javascript files into the .pbw file, whereas it should only be pebble-js-app.js
Increase the yellow of the selection bar, otherwise it just looks like white.
Reduce the height of the title bar text (used on the headlines page) to the height of the text contained within it. This leaves more space for the main content (the headlines menu list).
An error in the wscript file meant the generated Javascript file wasn't being included in the final pbw file. This change fixes this, with thanks to Olivier Gérardin (https://github.com/ogerardin) for highlighting the problem and identifying the fix.
To fix issue neal#6 preventing Pocket integration from working properly. This adds the fix identified by @ydyu see: neal#6 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make changes to support round screens (using text_flow), color and upgrade the build script to SDK 3.
The changes have #ifdefs to support rectangular screens and B&W displays, but it was necessary to make some changes to the original layout, so it the result doesn't look exactly the same on the original pebble. This will also add a progress bar for when headlines/stories are downloading to the pebble.