Avoid duplicate crates #12985
Open
Avoid duplicate crates #12985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12985 +/- ##
==========================================
- Coverage 69.92% 69.91% -0.01%
==========================================
Files 859 859
Lines 176306 176306
Branches 176306 176306
==========================================
- Hits 123275 123267 -8
- Misses 47868 47873 +5
- Partials 5163 5166 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nagisa
reviewed
Feb 24, 2025
| "rand", | ||
| "test_utils", | ||
| ] } | ||
| near-primitives = { workspace = true, features = ["clock", "solomon", "rand", "test_utils"] } |
There was a problem hiding this comment.
I'm pretty sure there was a really good reason for the path dependency and the duplicate here. Unfortunately we didn't leave the comment, but I don't think there's a need to take a risk and find out here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.