feat: Enable Block Streams Start from V1 Interruption #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darunrs
force-pushed
the
coordinatorInterruption
branch
from
ae414b5 to
0c1b189
Compare
morgsmccauley
requested changes
Jan 22, 2024
darunrs
force-pushed
the
coordinatorInterruption
branch
from
d447c48 to
4377ea4
Compare
morgsmccauley
approved these changes
Jan 23, 2024
darunrs
force-pushed
the
blockStreamerDeployment
branch
from
854dcae to
2ac0a86
Compare
darunrs
force-pushed
the
coordinatorInterruption
branch
from
4377ea4 to
955d236
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coordinator V2 currently defaults to starting block streams with the start_block_height value populated in the registry. In order for a smooth migration from V1 to V2, we instead want Coordinator V2 to create block streams starting where the current indexers left off.
Coordinator V1 now writes a last_published_block value for all indexers it manages on each matching block.
Coordinator V2's start_block_height setting workflow needs refactoring. This is due to the fact that the exisitng flow defauls to using start_block_height as its present in the registry even after we begin processing a stream from that block height. We need to refactor the flow to ensure we use the start block height once, and otherwise use redis last published block height, or fallback if not present.
New flow to handle edge cases will be tracked by #521.