fix: Allow re-provisioning of recently de-provisioned resources #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
force-pushed
the
fix/re-provisioning
branch
from
87b6719 to
7b6f318
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provisioning a recently de-provisioned Data Layer would silently fail. This is due to the fact that de/provisioning tasks are stored in-memory, keyed by a hash of the config. So if a provisioning task was recently completed, attempting to re-provision would return that same task.
This PR keys by random UUIDs, instead of hashes, so we can trigger multiple provisioning jobs for a given Indexer/Data Layer, allowing for the Provision > De-provision > Provision flow. To protect against re-provisioning an existing Data Layer, we only start the task after verifying it doesn't already exist. Also removed cache from
Provisionerto ensure we are getting accurate results.