Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary import in declaration file #471

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

ahmedissa
Copy link
Contributor

@ahmedissa ahmedissa commented Aug 27, 2024

Hi,

i was trying out @fastify/jwt in a new project. I have noticed my eslint rule "import/no-cycle" was failing,
because it can't resolve the import.

[Error - 23:34:21] EslintPluginImportResolveError: unable to load resolver "node".
Occurred while linting /app/src/plugins/auth/authorization.ts:2
Rule: "import/no-cycle"
    at requireResolver (/app/node_modules/eslint-module-utils/resolve.js:201:17)
    at fullResolve (/app/node_modules/eslint-module-utils/resolve.js:141:22)
    at Function.relative (/app/node_modules/eslint-module-utils/resolve.js:158:10)
    at remotePath (/app/node_modules/eslint-plugin-import/lib/ExportMap.js:811:381)
    at captureDependency (/app/node_modules/eslint-plugin-import/lib/ExportMap.js:817:463)
    at captureDependencyWithSpecifiers (/app/node_modules/eslint-plugin-import/lib/ExportMap.js:817:144)
    at /app/node_modules/eslint-plugin-import/lib/ExportMap.js:822:42
    at Array.forEach (<anonymous>)
    at ExportMap.parse (/app/node_modules/eslint-plugin-import/lib/ExportMap.js:821:427)
    at ExportMap.for (/app/node_modules/eslint-plugin-import/lib/ExportMap.js:807:201)

I don't have enough experiance in typescript. It can be possible the import exists for older versions.
if that case, you can close the PR and sorry for the inconvenience.

Issue: #472

Thanks

Copy link
Contributor

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@ahmedissa ahmedissa changed the title remove unnecessary import in declaration file remove unnecessary import in declaration file #472 Aug 27, 2024
@ahmedissa ahmedissa changed the title remove unnecessary import in declaration file #472 remove unnecessary import in declaration file Aug 27, 2024
@ahmedissa
Copy link
Contributor Author

i have no idea, why precheck is failing. 👯‍♂️

Issue/ #472

@simoneb simoneb linked an issue Aug 27, 2024 that may be closed by this pull request
@simoneb simoneb merged commit 3a3d96d into nearform:master Aug 27, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import 'node' in declartion file is un-resolvable.
2 participants