Fixed race condition when calling onCompleteCallback. #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed race condition when calling onCompleteCallback. The execution of the callback should not be tied to a timeout, should be executed after the email was sent or an error is catched. It is mentioned in javier-moreno's message in Design of Library issue.
The fix changes the behavior of
onCompleteCallback
to just set the fieldsuccessCallback
. In the block that sends the email, afinally
block is added to call the methodcallOnCompleteCallback
. This method does the same as the previous implementation ofonCompleteCallback
but gets theHandler
of theUI Thread
. By executing the callbacks on the UI thread, we avoid any errors if the callbacks (onSuccess
oronFail
) update UI elements.