Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit tests to cover module, request factory, and response factory. #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add unit tests to cover module, request factory, and response factory. #25

wants to merge 1 commit into from

Conversation

abacaphiliac
Copy link
Contributor

  • add unit tests to cover module, request factory, and response factory.
  • update module doc-block.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 2a36ca5 on abacaphiliac:add-tests into 70ed596 on neeckeloo:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 2a36ca5 on abacaphiliac:add-tests into 70ed596 on neeckeloo:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 2a36ca5 on abacaphiliac:add-tests into 70ed596 on neeckeloo:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 2a36ca5 on abacaphiliac:add-tests into 70ed596 on neeckeloo:master.

@abacaphiliac
Copy link
Contributor Author

ouch. the --prefer-lowest builds bit me ; )

@coveralls
Copy link

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 9c49623 on abacaphiliac:add-tests into 70ed596 on neeckeloo:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 9c49623 on abacaphiliac:add-tests into 70ed596 on neeckeloo:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 9c49623 on abacaphiliac:add-tests into 70ed596 on neeckeloo:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.3%) to 73.485% when pulling 9c49623 on abacaphiliac:add-tests into 70ed596 on neeckeloo:master.

@abacaphiliac
Copy link
Contributor Author

@neeckeloo ok, got the --prefer-lowest tests to pass. i was trying to cheat and use a real Application instance instead of mocking the interface and those instances are different between ZF2 and ZF3. who would've thought? : P

are you interested in only sending coverage to coveralls for a single build? and if so, which one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abacaphiliac @coveralls