Cli #771
Open
Cli #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added cli directory -wrapped run in other function -implement neodoc, readJSON using fs-extra
-have NOT tested properly yet
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/neherlab/covid19-scenarios/8wm8juszy |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
@r-s-rai Thanks! In order for me to be able to understand what's happening here, please:
Don't hesitate to sketch some bash/node/python scripts as well as a set of inputs/outputs for testing/showcasing the command-line part of the functionality. You probably already have accumulated some for development purposes. |
To facilitate fixing new issues
Have added a eslint-disable-next-line for two places using a non-null assertion. This seems safe because they are properties required by the neodoc parser
|
Code Climate has analyzed commit 1c2e65d and detected 0 issues on this pull request. View more on Code Climate. |
As best as I could tell, the only way to implement this with neodoc is to require defining both dates and transmission levels for each individual mitigation
when changing age distribution country via --ageDistribution, deserialization errors occurred. population.ageDistribution now updates with --ageDistribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues and PRs
Fixes issue #663
Description
Begin working more towards cli
So far based on issue #663, we have begun
-Added cli/ directory (and changed package.json to reflect that)
-Added the neodoc parser
-Wrapped run() in an exportable function
-Read severity and age distribution json files instead of "import get*" statements
-and doing the above with fs-extra
-Switching console.log to console.info/warn
Impacted Areas in the application
Can read json files and output results in a text file
Testing