Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/empty nodes #106

Merged
merged 12 commits into from
Jan 13, 2025
Merged

Fix/empty nodes #106

merged 12 commits into from
Jan 13, 2025

Conversation

mmolari
Copy link
Collaborator

@mmolari mmolari commented Jan 12, 2025

In the code the block_slice function takes care of slicing an alignment on an interval and return a new block with this sub-alignment. Occasionally this can produce an empty entry (when the slice covers a gap in the alignment). What we used to do was then finding all of these empty nodes and removing them afterwards.

I modified the code so that the block_slice function now returns an Option, which is None when a slice is empty. In this way empty nodes should never be produced, and it should not be needed to find and remove them afterwards.

@ivan-aksamentov ivan-aksamentov merged commit c43ac39 into rust Jan 13, 2025
14 checks passed
@ivan-aksamentov ivan-aksamentov deleted the fix/empty-nodes branch January 13, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants