Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the code the
block_slice
function takes care of slicing an alignment on an interval and return a new block with this sub-alignment. Occasionally this can produce an empty entry (when the slice covers a gap in the alignment). What we used to do was then finding all of these empty nodes and removing them afterwards.I modified the code so that the
block_slice
function now returns anOption
, which isNone
when a slice is empty. In this way empty nodes should never be produced, and it should not be needed to find and remove them afterwards.