-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polish alignment kernel options #113
Conversation
running
I need to investigate further, probably just a matter of 1-based vs 0-based indexing. Edit: indeed, according to the documentation while mmseqs standard output see uses 0-based indexing, the use of |
Now error messages are more informative: If mmseqs is not available in path:
If mmseqs command returns an error:
|
This follows `color_eyre` conventions and uses different sections to make error message prettier. It's important to note that any error can manifest with this exact message (e.g. if mmseqs requires libraries and they are missing, or if mmseqs binary is not executable, if it segfaults etc.), so I made the suggestion message a little more generic (not assuming that the error is "file not found"). ![Image](https://github.com/user-attachments/assets/346bf3f9-db27-4c7f-a2d1-cd642c0d008f)
This follows `color_eyre` conventions and uses different sections to make error message prettier. I think that chaining `.arg()` and then adding `-k` with `.args()` does not necessarily actually adds `-k`, but I don't know how to check it. So I opted for manually constructing all-in-one array of args, which I pass using a single `.args()` call. This also allow us to print the full command to the user and inspect it during debugging. Also refactored and simplified things a little. ![Image](https://github.com/user-attachments/assets/726a580f-c7f2-4e59-8f45-50089ab8125e)
This removes dev jargon from the help test. Non-technical users might not be familiar with it. Also added a link to mmseqs while we are on it.
This PR should contain the following changes:
minimap2-cli
option for the alignment kernel. The reason is that this should be redundant, given that we already ported the minimap library