Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge master to neo-build branch #3747

Merged
merged 16 commits into from
Feb 13, 2025
Merged

Merge master to neo-build branch #3747

merged 16 commits into from
Feb 13, 2025

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Feb 12, 2025 •
edited
Loading

Description

Fixes the dotnet format issue.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

nan01ab and others added 11 commits February 6, 2025 09:27
@nan01ab @Jim8y
@shargon @cschuchardt88
[Improve]: use IReadOnlyStoreView instead. (#3683)
d71ff19 
* Feature: use IReadOnlyStoreView when readonly access on storage

* fix an issue

* Fix `NeedSnapshot`

* fix: unify style

* Feature: use IReadOnlyStoreView when readonly access on storage

* Feature: use IReadOnlyStoreView when readonly access on storage

* Feature: add unit tests for NeedSnapshot and NeedApplicationEngine

---------

Co-authored-by: Jimmy <[email protected]>
Co-authored-by: Shargon <[email protected]>
Co-authored-by: Christopher Schuchardt <[email protected]>
@nan01ab @Jim8y
[Optimization]: check null when set IVerifiable.Witnesses (#3717)
038513a 
* Optimization: check null when set Witness for IVerifiable

* fix code style

* fix: add Witness null or not checking

---------

Co-authored-by: Jimmy <[email protected]>
@nan01ab @shargon
[Optimization]: make some unit tests more readable (#3716)
f99268b 
* Optimize: make some unit tests more readable

* Apply suggestions

---------

Co-authored-by: Fernando Diaz Toledano <[email protected]>
@shargon
Nullable storage classes (#3718)
24cf3cc 
* Nullable storage

* Fix ut

* Complete ut
@cschuchardt88
[fix] Docker Image (#3725)
b506936 
* Fix docker

* revert some changes
@Jim8y @shargon @nan01ab
[Style] optimize import (#3726)
ff9b33b 
* optimize import

* Apply suggestions from code review

Co-authored-by: nan01ab <[email protected]>

* Update src/Neo/Network/P2P/Payloads/Signer.cs

* Apply suggestions from code review

Co-authored-by: nan01ab <[email protected]>

* Fix signers

* Clean more

---------

Co-authored-by: Shargon <[email protected]>
Co-authored-by: nan01ab <[email protected]>
@Jim8y @vncoelho
update the readme (#3706)
00345b1 
Co-authored-by: Vitor Nazário Coelho <[email protected]>
@shargon
Refactor Storage classes (part 1) (#3735)
292540e 
* Refactor

* MemoryStore instead of IStore

* Fix Seek

* Renamed SnapshotCache to StoreCache

* fix header
@shargon @cschuchardt88
Nullable IO and plugins folders (#3719)
a40c9d7 
* Nullable IO and plugins

* Update ReflectionCache.cs

* Revert "Update ReflectionCache.cs"

This reverts commit c0a1124.

---------

Co-authored-by: Christopher Schuchardt <[email protected]>
@shargon
Avoid duplicate conditions (#3740)
720dcaa
@cschuchardt88
fix stuff (#3742)
4edcf2f 
* fix stuff

* fixed format

* if issue

* fixes

* fix bad code

* fix bad code
@cschuchardt88 cschuchardt88 self-assigned this Feb 12, 2025
@cschuchardt88 cschuchardt88 added Waiting for Review Easy-to-Review a simple edit; just a few lines labels Feb 12, 2025
@cschuchardt88 cschuchardt88 added the Critical Issues (bugs) that need to be fixed ASAP label Feb 12, 2025
@shargon shargon removed the Critical Issues (bugs) that need to be fixed ASAP label Feb 12, 2025
@shargon shargon merged commit 3f7c4de into neo-build Feb 13, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@Jim8y Jim8y Jim8y approved these changes

@nan01ab nan01ab Awaiting requested review from nan01ab

Assignees

@cschuchardt88 cschuchardt88

Labels
Easy-to-Review a simple edit; just a few lines Waiting for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cschuchardt88 @shargon @Jim8y @nan01ab