Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Plugin Loading by Assembly #3755

Merged
merged 12 commits into from
Feb 17, 2025

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Feb 13, 2025

Description

The EnableDynamicLoading property indicates that an assembly is a dynamically loaded component. The component could be a COM library or a non-COM library that can be used from a native host or used as a plugin. Setting this property to true has the following effects:

  • A .runtimeconfig.json file is generated.
  • RollForward is set to LatestMinor.
  • NuGet references are copied locally.

Added property below to all the plugins.

<EnableDynamicLoading>true</EnableDynamicLoading>

Fixes # (issue)

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to Directory.Build.props?

@cschuchardt88
Copy link
Member Author

Move to Directory.Build.props?

I will....

shargon
shargon previously approved these changes Feb 13, 2025
@shargon shargon self-requested a review February 13, 2025 11:28
nan01ab
nan01ab previously approved these changes Feb 13, 2025
@nan01ab
Copy link
Contributor

nan01ab commented Feb 13, 2025

LGTM

@shargon
Copy link
Member

shargon commented Feb 13, 2025

Move to Directory.Build.props?

I will....

Before merge please

@cschuchardt88 cschuchardt88 dismissed stale reviews from shargon and nan01ab via 3b7b167 February 13, 2025 16:51
@cschuchardt88
Copy link
Member Author

Move to Directory.Build.props?

I will....

Before merge please

DONE!!! 😃

@cschuchardt88 cschuchardt88 added the Needs Reapproved Already "ready for merge" label Feb 13, 2025
shargon
shargon previously approved these changes Feb 13, 2025
nan01ab
nan01ab previously approved these changes Feb 14, 2025
@cschuchardt88 cschuchardt88 removed the Needs Reapproved Already "ready for merge" label Feb 14, 2025
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check conflict

@shargon shargon dismissed stale reviews from nan01ab and themself via c85ebd8 February 16, 2025 15:16
@shargon shargon merged commit fe0f732 into neo-project:master Feb 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants