Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ECPoint serialization #3757

Merged
merged 7 commits into from
Feb 14, 2025
Merged

Optimize ECPoint serialization #3757

merged 7 commits into from
Feb 14, 2025

Conversation

shargon
Copy link
Member

@shargon shargon commented Feb 13, 2025

Description

Avoid BinaryWritter on ECPoint like with UIntXXX

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Current

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88
Copy link
Member

Please fix

Error: /home/runner/work/neo/neo/tests/Neo.UnitTests/TestUtils.cs(46,40): error CS1503: Argument 1: cannot convert from 'Neo.IO.ISerializable' to 'byte' [/home/runner/work/neo/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj]
Error: /home/runner/work/neo/neo/tests/Neo.UnitTests/SmartContract/UT_KeyBuilder.cs(94,29): error CS1503: Argument 1: cannot convert from 'Neo.IO.ISerializable' to 'byte' [/home/runner/work/neo/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj]
Error: /home/runner/work/neo/neo/tests/Neo.UnitTests/SmartContract/UT_KeyBuilder.cs(107,29): error CS1503: Argument 1: cannot convert from 'Neo.IO.ISerializable' to 'byte' [/home/runner/work/neo/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj]
Error: /home/runner/work/neo/neo/tests/Neo.Plugins.OracleService.Tests/TestUtils.cs(36,40): error CS1503: Argument 1: cannot convert from 'Neo.IO.ISerializable' to 'byte' [/home/runner/work/neo/neo/tests/Neo.Plugins.OracleService.Tests/Neo.Plugins.OracleService.Tests.csproj]
Error: /home/runner/work/neo/neo/tests/Neo.UnitTests/TestUtils.cs(46,40): error CS1503: Argument 1: cannot convert from 'Neo.IO.ISerializable' to 'byte' [/home/runner/work/neo/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj]
Error: /home/runner/work/neo/neo/tests/Neo.UnitTests/SmartContract/UT_KeyBuilder.cs(94,29): error CS1503: Argument 1: cannot convert from 'Neo.IO.ISerializable' to 'byte' [/home/runner/work/neo/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj]
Error: /home/runner/work/neo/neo/tests/Neo.UnitTests/SmartContract/UT_KeyBuilder.cs([107](https://github.com/neo-project/neo/actions/runs/13315568797/job/37188684692?pr=3757#step:4:108),29): error CS1503: Argument 1: cannot convert from 'Neo.IO.ISerializable' to 'byte' [/home/runner/work/neo/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj]
Error: /home/runner/work/neo/neo/tests/Neo.Plugins.OracleService.Tests/TestUtils.cs(36,40): error CS1503: Argument 1: cannot convert from 'Neo.IO.ISerializable' to 'byte' [/home/runner/work/neo/neo/tests/Neo.Plugins.OracleService.Tests/Neo.Plugins.OracleService.Tests.csproj]

@shargon shargon changed the title Optimize PubKey serialization Optimize ECPoint serialization Feb 14, 2025
@shargon shargon merged commit c1a0582 into master Feb 14, 2025
7 checks passed
@shargon shargon deleted the optimize-pubKey branch February 14, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants