Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Optimization]: Make murmur32 appendable and faster. #3760

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[Optimization]: Make murmur32 appendable and faster. #3760

wants to merge 7 commits into from
+125 −31

Conversation

nan01ab
Copy link
Contributor

@nan01ab nan01ab commented Feb 13, 2025

Description

ImplementNonCryptographicHashAlgorithm for Murmure32.
And make it faster.

Before:

BenchmarkDotNet v0.14.0, macOS Sequoia 15.1.1 (24B2091) [Darwin 24.1.0]
Apple M4 Pro, 1 CPU, 14 logical and 14 physical cores
.NET SDK 9.0.102
  [Host]     : .NET 9.0.1 (9.0.124.61010), Arm64 RyuJIT AdvSIMD
  DefaultJob : .NET 9.0.1 (9.0.124.61010), Arm64 RyuJIT AdvSIMD


| Method                | Mean       | Error     | StdDev    |
|---------------------- |-----------:|----------:|----------:|
| Murmur32_HashToUInt32 | 138.497 us | 0.8307 us | 0.7771 us |

After:

BenchmarkDotNet v0.14.0, macOS Sequoia 15.1.1 (24B2091) [Darwin 24.1.0]
Apple M4 Pro, 1 CPU, 14 logical and 14 physical cores
.NET SDK 9.0.102
  [Host]     : .NET 9.0.1 (9.0.124.61010), Arm64 RyuJIT AdvSIMD
  DefaultJob : .NET 9.0.1 (9.0.124.61010), Arm64 RyuJIT AdvSIMD


| Method                | Mean       | Error     | StdDev    |
|---------------------- |-----------:|----------:|----------:|
| Murmur32_HashToUInt32 |  89.359 us | 0.1607 us | 0.1424 us |

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

cschuchardt88
cschuchardt88 previously approved these changes Feb 13, 2025
View reviewed changes
shargon
shargon reviewed Feb 13, 2025
View reviewed changes
src/Neo/Cryptography/Murmur32.cs
/// </summary>
/// <param name="data">The input to compute the hash code for.</param>
/// <returns>The computed hash code in uint.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public uint ComputeHashUInt32(ReadOnlySpan<byte> data)
{
Initialize();
Reset();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't reset twice when only one is computed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't reset twice when only one is computed?

Cannot.
Because the ComputeHashUInt32 may be called multi times.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't reset twice when only one is computed?

The overhead of Reset is trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cschuchardt88 cschuchardt88 cschuchardt88 left review comments

@shargon shargon shargon approved these changes

Assignees

@nan01ab nan01ab

Labels
Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nan01ab @shargon @cschuchardt88