Improve MaxNestingDepth of WitnessCondition

[roman-khimov]

Description

While digging into nspcc-dev/neo-go#3809 we've checked C# code as well and I think the main problem that got us to that issue is that we have an incorrect MaxNestingDepth. The first patch here adds a UT for nesting, notice that it already has three levels for the "correct" set. But it's completely hidden in the code because the check is not performed at all for items that can not have any children. I think it'd be nice to change it, simplifying the check itself (currently it's duplicated between different types of conditions) and making the MaxNestingDepth have a real number of levels allowed.

Count curly braces in

                        "condition" : {
                           "type" : "And",
                           "expressions" : [
                              {
                                 "hash" : "0x2ba94444d43c9a084a5660982a9f95f43f07422e",
                                 "type" : "CalledByContract"
                              },
                              {
                                 "type" : "Or",
                                 "expressions" : [
                                    {
                                       "type" : "ScriptHash",
                                       "hash" : "0xd2a4cff31913016155e38e474a2c06d08be276cf"
                                    },
                                    {
                                       "hash" : "0xef4073a0f2b305a38ec4050e4d3d28bc40ea63f5",
                                       "type" : "ScriptHash"
                                    }
                                 ]
                              }
                           ]
                        }

if in doubt.

Type of change

No behavior changes here.

• [*] Optimization (the change is only an optimization)
• [*] Style (the change is only a code style for better maintenance or standard purpose)

[cschuchardt88]

I thought it used to be 2 for max depth for WitnessCondition. I remember seeing this when I built transaction builder. I tried crashing nodes way back when, it was more than 2. Even with RcpServer parameters

[cschuchardt88]

@roman-khimov please run dotnet format -v diag in the root of repo, than recommit.

[roman-khimov]

@roman-khimov please run dotnet format -v diag in the root of repo, than recommit.

Actually that's exactly the formatting I got after dotnet format --no-restore --include <modified files> (--no-restore because I had to use SDK 8.0.406 and that's because of dotnet/sdk#46780). I always try to autoformat, but it's always wrong for me for some reason. Maybe it's a sign I shouldn't be touching C#. But I still do from time to time.

Thanks for fixing this, @shargon.

[nan01ab]

Is it compatible with the previous implementation ?

[roman-khimov]

Is it compatible with the previous implementation ?

⬆️

No behavior changes here.