Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when executing /neoforge tags minecraft:worldgen/biome get with any parameter. #1850

Closed
Thomas1034 opened this issue Jan 14, 2025 · 2 comments · Fixed by #1851
Closed
Assignees
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error

Comments

@Thomas1034
Copy link

When I attempted to run /neoforge tags minecraft:worldgen/biome get c:is_cold/overworld in a world (run from the development environment), I was presented with this error:

[22:20:46] [Server thread/ERROR] [minecraft/Commands]: '/neoforge tags minecraft:worldgen/biome get c:is_cold/overworld' threw an exception
java.lang.ClassCastException: class net.minecraft.tags.TagKey cannot be cast to class net.minecraft.resources.ResourceKey (net.minecraft.tags.TagKey and net.minecraft.resources.ResourceKey are in module [email protected] of loader 'TRANSFORMER' @4b2a30d)
	at TRANSFORMER/[email protected]/net.neoforged.neoforge.server.command.TagsCommand.listTagElements(TagsCommand.java:125) ~[neoforge-21.4.54-beta-minecraft.jar%23216!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.neoforged.neoforge.server.command.TagsCommand.lambda$register$7(TagsCommand.java:82) ~[neoforge-21.4.54-beta-minecraft.jar%23216!/:?] {re:classloading}
	at MC-BOOTSTRAP/[email protected]/com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.3.10.jar%23138!/:?] {}
	at TRANSFORMER/[email protected]/net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:29) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:13) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.commands.execution.CommandQueueEntry.execute(CommandQueueEntry.java:5) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:103) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.commands.Commands.executeCommandInContext(Commands.java:368) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.commands.Commands.performCommand(Commands.java:289) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.server.network.ServerGamePacketListenerImpl.performUnsignedChatCommand(ServerGamePacketListenerImpl.java:1382) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$7(ServerGamePacketListenerImpl.java:1369) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.server.TickTask.run(TickTask.java:18) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:155) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:905) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:177) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:888) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:882) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:115) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:851) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:735) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:278) ~[neoforge-21.4.54-beta-minecraft.jar%23215!/:?] {re:classloading,pl:accesstransformer:B}
	at java.base/java.lang.Thread.run(Thread.java:1583) [?:?] {}

As you can see, a TagKey apparently cannot be cast to a ResourceKey.

@dhyces
Copy link
Contributor

dhyces commented Jan 14, 2025

Can confirm, code was incorrectly adjusted to <ResourceKey>cast rather than <TagKey>cast commit e18c200. Affects 1.21.4 back down to 1.21.2.

@dhyces dhyces added 1.20.4 Targeted at Minecraft 1.20.4 1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error and removed 1.20.4 Targeted at Minecraft 1.20.4 labels Jan 14, 2025
@dhyces dhyces self-assigned this Jan 14, 2025
@neoforged-releases
Copy link

🚀 This issue has been resolved in NeoForge version 21.4.57-beta, as part of #1851.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants