Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.4] Fix TagsCommand tag cast error #1851

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

dhyces
Copy link
Contributor

@dhyces dhyces commented Jan 14, 2025

Code was incorrectly adjusted to a <ResourceKey>cast rather than a <TagKey>cast in commit e18c200. This simply corrects it to the right type for the right get method.

Closes #1850

@dhyces dhyces added bug A bug or error 1.21.4 Targeted at Minecraft 1.21.4 labels Jan 14, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 14, 2025

  • Publish PR to GitHub Packages

Last commit published: 99e466eec4f3e316dfdc2f9597cab84b463918a0.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1851' // https://github.com/neoforged/NeoForge/pull/1851
        url 'https://prmaven.neoforged.net/NeoForge/pr1851'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1851.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1851
cd NeoForge-pr1851
curl -L https://prmaven.neoforged.net/NeoForge/pr1851/net/neoforged/neoforge/21.4.56-beta-pr-1851-fix-tags-command-cast/mdk-pr1851.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and works to fix the issue.

@sciwhiz12 sciwhiz12 merged commit 9d2c3aa into neoforged:1.21.x Jan 14, 2025
7 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.57-beta.

@dhyces dhyces deleted the fix/tags-command-cast branch January 14, 2025 20:12
Soaryn pushed a commit to Soaryn/EnergyHandlerPR that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when executing /neoforge tags minecraft:worldgen/biome get with any parameter.
4 participants