-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add c:flowers
, c:flowers/tall
, and c:flowers/small
block and item tags
#1825
Add c:flowers
, c:flowers/tall
, and c:flowers/small
block and item tags
#1825
Conversation
Last commit published: b089c674a2764d3417cdd67bac660daff3669144. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1825' // https://github.com/neoforged/NeoForge/pull/1825
url 'https://prmaven.neoforged.net/NeoForge/pr1825'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1825
cd NeoForge-pr1825
curl -L https://prmaven.neoforged.net/NeoForge/pr1825/net/neoforged/neoforge/21.4.59-beta-pr-1825-FlowerTagRevival/mdk-pr1825.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
🚀 This PR has been released as NeoForge version |
Mojang has recently rid
minecraft:tall_flowers
block tag andminecraft:tall_flowers
/minecraft:flowers
item tags.What this PR aims to do is bring back and duplicate these flower tags under
c
namespace to make it safer for Modders to use without worry about Mojang deleting the rest of the flower tags in the future. We had multiple people ask where the flower item tag went so there is quite a number of people relying on a tag of flowers.The non-tag entries of the flower tags are in same order as the tags in past (with exception to eye blossom because vanilla has the open and closed entry far apart in the vanilla for no logical reason which drove me insane)
For Fabric side, the
c
flower tags that still have a vanilla equivalent are aliased together.I also added entries to log warning to find people using vanilla tags that no longer exist and guide them to the new
c
tagsBlocks:
c:flowers/tall
c:flowers/small
c:flowers
Items:
c:flowers/tall
c:flowers/small
c:flowers
Any issues with this? Is there any flower subcategory that is strongly desired beyond tall/small?
Fabric PR: FabricMC/fabric#4352