Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate ATs for villager ItemListings #1878

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

Matyrobbrt
Copy link
Member

Add rules to generate ATs that make ItemListings and their constructors public for use in mods that add custom trades.

@Matyrobbrt Matyrobbrt added the enhancement New (or improvement to existing) feature or request label Jan 20, 2025
@neoforged-automation neoforged-automation bot added the 1.21.4 Targeted at Minecraft 1.21.4 label Jan 20, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 20, 2025

  • Publish PR to GitHub Packages

Last commit published: d9525120db54d86cc161c53a1bf8996dd5c8d9c5.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1878' // https://github.com/neoforged/NeoForge/pull/1878
        url 'https://prmaven.neoforged.net/NeoForge/pr1878'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1878.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1878
cd NeoForge-pr1878
curl -L https://prmaven.neoforged.net/NeoForge/pr1878/net/neoforged/neoforge/21.4.68-beta-pr-1878-villager-item-listing-ats/mdk-pr1878.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@marchermans marchermans merged commit 1fabdf8 into neoforged:1.21.x Jan 20, 2025
7 checks passed
@Matyrobbrt Matyrobbrt deleted the villager-item-listing-ats branch January 20, 2025 09:17
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.67-beta.

Soaryn pushed a commit to Soaryn/EnergyHandlerPR that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants