Add a biome villager types data map to replace VillagerType#BY_BIOME

[Matyrobbrt]

This PR adds a neoforge:villager_types biome data map to replace VillagerType#BY_BIOME, allowing mods to change the type of the villagers spawned in their own biomes.

To avoid a sudden breaking change, the map will still be used for now, but the fallback to it will be removed in 1.22.

See #1875 for context of making this PR.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: aa5a0889d9e2b118cde82f38d6eb3e81fd2414b1.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.4.79-beta-pr-1879-biome-villagers-data-map
• 📦 net.neoforged:testframework:21.4.79-beta-pr-1879-biome-villagers-data-map

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1879' // https://github.com/neoforged/NeoForge/pull/1879
        url 'https://prmaven.neoforged.net/NeoForge/pr1879'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1879.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1879
cd NeoForge-pr1879
curl -L https://prmaven.neoforged.net/NeoForge/pr1879/net/neoforged/neoforge/21.4.79-beta-pr-1879-biome-villagers-data-map/mdk-pr1879.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[JT122406]

Looks good I would just add somewhere stating the default value is plains villager type so people can easily see that

[JT122406]

Any movement on this?

[Matyrobbrt]

@neoforged/bots backport 1.21.1

[neoforged-automation]

Backporting to 1.21.1...

[neoforged-automation]

@Matyrobbrt backport to 1.21.1 failed.

Click for failure reason

Command 'git apply --ignore-whitespace --recount -C0 __diff' failed execution with error: error: patch failed: src/main/java/net/neoforged/neoforge/common/data/internal/NeoForgeDataMapsProvider.java:24
error: src/main/java/net/neoforged/neoforge/common/data/internal/NeoForgeDataMapsProvider.java: patch does not apply

https://github.com/neoforged/PRActionRunner/actions/runs/13101887154

[neoforged-releases]

🚀 This PR has been released as NeoForge version 21.4.79-beta.